fix numpy 1.20 DeprecationWarnings #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=======================================
Coverage 80.25% 80.25%
=======================================
Files 136 136
Lines 14449 14449
=======================================
Hits 11596 11596
Misses 2853 2853
Continue to review full report at Codecov.
|
dwhswenson
approved these changes
Feb 16, 2021
Member
|
Huh... Release notes on this say (emphasis mine):
I'm pretty sure I distinctly remember my confusion when: >>> np.True is True
False(Edit: maybe not that exact syntax, but that was the problem -- testing against I must be getting old. LGTM. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of
numpy1.20came a coupleDeprecationWarnings, mainly aboutnp.floatornp.booljust being an alias for the python internal. The one Warning that is left (in my test setup) comes fromopenmmtoolsand is handled in choderalab/openmmtools#497