TYP: fix count_nonzero signature
#28774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Apr 19, 2025
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
Member
Author
|
Thanks Joren. |
Member
Right back at ya |
penguinpee
added a commit
to penguinpee/numpy
that referenced
this pull request
Sep 25, 2025
The return type of the function was changed in 2.3.0, but the docstring remained the same (numpygh-28774).
penguinpee
added a commit
to penguinpee/numpy
that referenced
this pull request
Oct 6, 2025
The return type of the function was changed in 2.3.0, but the docstring remained the same (numpygh-28774).
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Oct 13, 2025
The return type of the function was changed in 2.3.0, but the docstring remained the same (numpygh-28774).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28750.
This fixes the following valid usage in https://github.com/data-apis/array-api-compat/blob/16978e63b744185bc4ced4677c822468e6ddebd2/array_api_compat/numpy/_aliases.py#L126-L127 from being falsely rejected: