test_runner: simplify test start time tracking

cjihrig · nodejs-github-bot · commit 878047be0b2f · 2024-03-25T13:23:34.000Z
This commit simplifies the logic for tracking test start time. The start time is now set only when a test/suite begins running. If the test/suite never runs, a fallback is provided in postRun(). PR-URL: #52182 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -507,7 +507,6 @@ class Test extends AsyncResource {
     }
 
     if (preventAddingSubtests) {
-      test.startTime = test.startTime || hrtime();
       test.fail(
         new ERR_TEST_FAILURE(
           'test could not be started because its parent finished',
@@ -537,7 +536,6 @@ class Test extends AsyncResource {
         kCancelledByParent,
       ),
     );
-    this.startTime = this.startTime || this.endTime; // If a test was canceled before it was started, e.g inside a hook
     this.cancelled = true;
     this.abortController.abort();
   }
@@ -763,12 +761,13 @@ class Test extends AsyncResource {
   }
 
   postRun(pendingSubtestsError) {
+    this.startTime ??= hrtime();
+
     // If the test was failed before it even started, then the end time will
     // be earlier than the start time. Correct that here.
     if (this.endTime < this.startTime) {
       this.endTime = hrtime();
     }
-    this.startTime ??= this.endTime;
 
     // The test has run, so recursively cancel any outstanding subtests and
     // mark this test as failed if any subtests failed.
diff --git a/test/fixtures/test-runner/output/hooks_spec_reporter.snapshot b/test/fixtures/test-runner/output/hooks_spec_reporter.snapshot
@@ -11,10 +11,10 @@
 
  describe hooks - no subtests (*ms)
  before throws
-   1
+   1 (*ms)
     'test did not finish before its parent and was cancelled'
 
-   2
+   2 (*ms)
     'test did not finish before its parent and was cancelled'
 
  before throws (*ms)
@@ -390,7 +390,7 @@
 
  - after() called
  run after when before throws
-   1
+   1 (*ms)
     'test did not finish before its parent and was cancelled'
 
  run after when before throws (*ms)
@@ -422,11 +422,11 @@
  failing tests:
 
 *
- 1
+ 1 (*ms)
   'test did not finish before its parent and was cancelled'
 
 *
- 2
+ 2 (*ms)
   'test did not finish before its parent and was cancelled'
 
 *
@@ -772,7 +772,7 @@
       *
 
 *
- 1
+ 1 (*ms)
   'test did not finish before its parent and was cancelled'
 
 *

Original file line number	Diff line number	Diff line change
`@@ -11,10 +11,10 @@`
`11`	`11`
`12`	`12`	`describe hooks - no subtests (*ms)`
`13`	`13`	`before throws`
`14`		`- 1`
	`14`	`+ 1 (*ms)`
`15`	`15`	`'test did not finish before its parent and was cancelled'`
`16`	`16`
`17`		`- 2`
	`17`	`+ 2 (*ms)`
`18`	`18`	`'test did not finish before its parent and was cancelled'`
`19`	`19`
`20`	`20`	`before throws (*ms)`
`@@ -390,7 +390,7 @@`
`390`	`390`
`391`	`391`	`- after() called`
`392`	`392`	`run after when before throws`
`393`		`- 1`
	`393`	`+ 1 (*ms)`
`394`	`394`	`'test did not finish before its parent and was cancelled'`
`395`	`395`
`396`	`396`	`run after when before throws (*ms)`
`@@ -422,11 +422,11 @@`
`422`	`422`	`failing tests:`
`423`	`423`
`424`	`424`	`*`
`425`		`- 1`
	`425`	`+ 1 (*ms)`
`426`	`426`	`'test did not finish before its parent and was cancelled'`
`427`	`427`
`428`	`428`	`*`
`429`		`- 2`
	`429`	`+ 2 (*ms)`
`430`	`430`	`'test did not finish before its parent and was cancelled'`
`431`	`431`
`432`	`432`	`*`
`@@ -772,7 +772,7 @@`
`772`	`772`	`*`
`773`	`773`
`774`	`774`	`*`
`775`		`- 1`
	`775`	`+ 1 (*ms)`
`776`	`776`	`'test did not finish before its parent and was cancelled'`
`777`	`777`
`778`	`778`	`*`