test_runner: avoid overwriting root start time

cjihrig · web-flow · commit 592c6907bfe1 · 2024-03-11T03:18:07.000Z
This commit ensures the root test start time is not overwritten when top level before()/after() hooks are run. PR-URL: #52020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -620,7 +620,7 @@ class Test extends AsyncResource {
     if (this.parent !== null) {
       this.parent.activeSubtests++;
     }
-    this.startTime = hrtime();
+    this.startTime ??= hrtime();
 
     if (this[kShouldAbort]()) {
       this.postRun();
diff --git a/test/fixtures/test-runner/root-duration.mjs b/test/fixtures/test-runner/root-duration.mjs
@@ -0,0 +1,7 @@
+import { test, after } from 'node:test';
+
+after(() => {});
+
+test('a test with some delay', (t, done) => {
+  setTimeout(done, 50);
+});
diff --git a/test/parallel/test-runner-root-duration.js b/test/parallel/test-runner-root-duration.js
@@ -0,0 +1,25 @@
+'use strict';
+const { spawnPromisified } = require('../common');
+const fixtures = require('../common/fixtures');
+const { strictEqual } = require('node:assert');
+const { test } = require('node:test');
+
+test('root duration is longer than test duration', async () => {
+  const {
+    code,
+    stderr,
+    stdout,
+  } = await spawnPromisified(process.execPath, [
+    fixtures.path('test-runner/root-duration.mjs'),
+  ]);
+
+  strictEqual(code, 0);
+  strictEqual(stderr, '');
+  const durations = [...stdout.matchAll(/duration_ms:? ([.\d]+)/g)];
+  strictEqual(durations.length, 2);
+  const testDuration = Number.parseFloat(durations[0][1]);
+  const rootDuration = Number.parseFloat(durations[1][1]);
+  strictEqual(Number.isNaN(testDuration), false);
+  strictEqual(Number.isNaN(rootDuration), false);
+  strictEqual(rootDuration >= testDuration, true);
+});

Original file line number	Diff line number	Diff line change
`@@ -620,7 +620,7 @@ class Test extends AsyncResource {`
`620`	`620`	`if (this.parent !== null) {`
`621`	`621`	`this.parent.activeSubtests++;`
`622`	`622`	`}`
`623`		`- this.startTime = hrtime();`
	`623`	`+ this.startTime ??= hrtime();`
`624`	`624`
`625`	`625`	`if (this[kShouldAbort]()) {`
`626`	`626`	`this.postRun();`