deps: V8: cherry-pick f8d5e576b814

richardlau · nodejs-github-bot · commit 0d4bc4c40ee4 · 2024-03-23T19:49:41.000Z
Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: #52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/common.gypi b/common.gypi
@@ -37,7 +37,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.13',
+    'v8_embedder_string': '-node.14',
 
     ##### V8 defaults for Node.js #####
 
diff --git a/deps/v8/BUILD.gn b/deps/v8/BUILD.gn
@@ -1664,6 +1664,10 @@ config("toolchain") {
       # of `this` in capture-by-value lambdas and preventing a build roll which
       # enables C++20 (see https://crbug.com/1374227).
       "-Wno-deprecated",
+
+      # Fix build with older versions of GCC
+      # Ported from v8 bazel: https://crrev.com/c/3368869
+      "-Wno-stringop-overflow",
     ]
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1664,6 +1664,10 @@ config("toolchain") {`
`1664`	`1664`	# of `this` in capture-by-value lambdas and preventing a build roll which
`1665`	`1665`	`# enables C++20 (see https://crbug.com/1374227).`
`1666`	`1666`	`"-Wno-deprecated",`
	`1667`	`+`
	`1668`	`+ # Fix build with older versions of GCC`
	`1669`	`+ # Ported from v8 bazel: https://crrev.com/c/3368869`
	`1670`	`+ "-Wno-stringop-overflow",`
`1667`	`1671`	`]`
`1668`	`1672`	`}`
`1669`	`1673`