-
-
Notifications
You must be signed in to change notification settings - Fork 1
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: nikolaydubina/go-enum-encoding
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: nikolaydubina/go-enum-encoding
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.5.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 15 files changed
- 2 contributors
Commits on May 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ef0efe0 - Browse repository at this point
Copy the full SHA ef0efe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6055f6d - Browse repository at this point
Copy the full SHA 6055f6dView commit details
Commits on Aug 19, 2024
-
Validate the enum type matches the
-typeargWithout validation, multiple definitions of multiple enums in the same file would be mixed, as well as comments with `json:"..."` on `val` or `const` statments. Fixes #24
Configuration menu - View commit details
-
Copy full SHA for fc0efcf - Browse repository at this point
Copy the full SHA fc0efcfView commit details -
Improve matching of enum type, abort when unable to match
Detect type when explicitly available. Infer when implicity known via a composite type (of the first enum value). Punt with warning when neither is possible (i.e. when type not explicitly stated, and value is literal or expression). Exit with error when type canont be matched. Fixes #24
Configuration menu - View commit details
-
Copy full SHA for 90d037f - Browse repository at this point
Copy the full SHA 90d037fView commit details -
Match enum values based on location of
#go:generatecommentThe `const`/`var` block is expected to be found in the line immediately subsequent to that of the `#go:generate`. Use the latter to precisely locate the relevant block. This significantly simplified the solution to the original issue. Fixes #24
Configuration menu - View commit details
-
Copy full SHA for 9c20d9d - Browse repository at this point
Copy the full SHA 9c20d9dView commit details -
Add tests for multiple enums in one file and missing enums
Add the env variable GOLINE=..., needed to vet the relevant const/var block. Add a test case with multiple enum definition in the same file. Add a test case to expect an error when the const/var block is not found in the line following the `//go:generate ...` comment. Remove unneeded output files from internal/testdata (uneeded copies of the same files in internal/testdata/exp).
Configuration menu - View commit details
-
Copy full SHA for 121a512 - Browse repository at this point
Copy the full SHA 121a512View commit details
Commits on Aug 20, 2024
-
Signed-off-by: Nikolay Dubina <nikolay.dubina.pub@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 151c886 - Browse repository at this point
Copy the full SHA 151c886View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaa4957 - Browse repository at this point
Copy the full SHA aaa4957View commit details -
Configuration menu - View commit details
-
Copy full SHA for dce6cc1 - Browse repository at this point
Copy the full SHA dce6cc1View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.4.1...v1.5.0