Skip to content

Comments attached to wrong lines #8374

@ScyllaPiotr

Description

@ScyllaPiotr
  • Extension version: 0.124.1
  • VSCode Version: 1.107.1
  • OS: Fedora 42
  • Repository Clone Configuration (single repository/fork of an upstream repository): fork of an upstream repo
  • GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): GitHub.com

See here for the affected PR and the comment: https://github.com/scylladb/scylladb/pull/27386/files#r2643211612

When viewing with a browser, the comment is in the right place, right where there are 7 lines removed and the one below:
for shard in iterate_over_describe_stream(dynamodbstreams, arn, time.time() + 60):
is added instead.
In VS Code the comment is shown associated to the wrong lines - to the new lines starting from 1409, not the old lines starting from 1409.

Steps to Reproduce:

  1. Install the "GitHub Pull Requests" extension to VS Code.
  2. View the affected PR in VS Code.
  3. Search for a string from the comment to see it in VS Code

The right placement when viewed with Chromium:
Image

The wrong placement when viewed in VS Code:
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    info-neededIssue requires more information from poster

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions