Skip to content

Add option to allow ':' in ARNs #13296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Add option to allow ':' in ARNs #13296

merged 2 commits into from
Oct 23, 2025

Conversation

@baermat
Copy link
Member

@baermat baermat commented Oct 22, 2025

Motivation

Certain services (like IoT) allow colons in their resource names, and therefore in their arns. This PR adds an option for this

Changes

  • add option to _resource_arn to allow colons

@baermat baermat added docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Oct 22, 2025
@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 367 tests  +1   20 617 ✅ +1   16m 21s ⏱️ +48s
     1 suites ±0    1 750 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 412623c. ± Comparison against base commit 06df84d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 25s ⏱️ +8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 412623c. ± Comparison against base commit 06df84d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 38m 36s ⏱️ + 1m 2s
5 252 tests ±0  4 737 ✅ ±0  515 💤 ±0  0 ❌ ±0 
5 258 runs  ±0  4 737 ✅ ±0  521 💤 ±0  0 ❌ ±0 

Results for commit 412623c. ± Comparison against base commit 06df84d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   2h 0m 2s ⏱️ -6s
4 878 tests ±0  4 523 ✅ ±0  355 💤 ±0  0 ❌ ±0 
4 880 runs  ±0  4 523 ✅ ±0  357 💤 ±0  0 ❌ ±0 

Results for commit 412623c. ± Comparison against base commit 06df84d.

♻️ This comment has been updated with latest results.

@baermat baermat marked this pull request as ready for review October 22, 2025 13:22
viren-nadkarni
viren-nadkarni approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suggest adding a unit-test that covers this new argument. Looks good otherwise!

@baermat baermat merged commit 2467f0d into main Oct 23, 2025
42 checks passed
@baermat baermat deleted the iot/fix-group-names branch October 23, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baermat @viren-nadkarni