Skip to content

S3: clean up leftover legacy code #13271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

S3: clean up leftover legacy code #13271

merged 1 commit into from
Oct 16, 2025

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Oct 14, 2025 •
edited
Loading

Motivation

While working on #13250, I noticed some legacy code that isn't used anymore and is a remnant that wasn't cleaned up when removing the legacy S3 provider (in #11746)

This PR cleans up a bit 🧹

Changes

  • clean up and remove legacy code related to removed Virtual Host proxying logic
  • rename a method to not talk about "native" anymore which was used to make a distinction between pure LocalStack implement vs Moto

@bentsku bentsku added this to the 4.10 milestone Oct 14, 2025
@bentsku bentsku self-assigned this Oct 14, 2025
@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 15s ⏱️
  533 tests 481 ✅  52 💤 0 ❌
1 066 runs  962 ✅ 104 💤 0 ❌

Results for commit 61c9aca.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Test Results - Preflight, Unit

22 337 tests  ±0   20 587 ✅ ±0   16m 7s ⏱️ -1s
     1 suites ±0    1 750 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 61c9aca. ± Comparison against base commit 395f363.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 28s ⏱️ +9s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 61c9aca. ± Comparison against base commit 395f363.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 41m 26s ⏱️
2 001 tests 1 835 ✅ 166 💤 0 ❌
2 007 runs  1 835 ✅ 172 💤 0 ❌

Results for commit 61c9aca.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

LocalStack Community integration with Pro

    2 files      2 suites   1h 18m 54s ⏱️
1 977 tests 1 807 ✅ 170 💤 0 ❌
1 979 runs  1 807 ✅ 172 💤 0 ❌

Results for commit 61c9aca.

@bentsku bentsku marked this pull request as ready for review October 15, 2025 09:29
@bentsku bentsku requested a review from k-a-il as a code owner October 15, 2025 09:29
k-a-il
k-a-il approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bentsku bentsku merged commit cc8cc23 into main Oct 16, 2025
68 checks passed
@bentsku bentsku deleted the s3-clean-up branch October 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-a-il k-a-il k-a-il approved these changes

Assignees

@bentsku bentsku

Labels

aws:s3 Amazon Simple Storage Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

3 participants

@bentsku @k-a-il