Skip to content

CFn: handle invalid GetAtt validation #13241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

CFn: handle invalid GetAtt validation #13241

merged 2 commits into from
Oct 8, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Oct 8, 2025

Motivation

While triaging CFn issues we found a couple of errors that were

  File ""/opt/code/localstack/.venv/lib/python3.13/site-packages/localstack/services/cloudformation/engine/v2/change_set_model_preproc.py"", line 563, in _resolve_attribute
    attribute_name = arguments_list[1]
                     ~~~~~~~~~~~~~~^^^
localstack.aws.api.core.CommonServiceException: exception while calling cloudformation.UpdateStack: list index out of range

This is due to an invalid usage of the Fn::GetAtt intrinsic which expects two arguments, the logical resource id and the attribute to fetch. On AWS this raises a validation error during create change set.

Changes

Add two tests covering this situation

@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   15m 59s ⏱️ +18s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a31ed23. ± Comparison against base commit 9af2464.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 22s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a31ed23. ± Comparison against base commit 9af2464.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results - Alternative Providers

582 tests   330 ✅  25m 52s ⏱️
  1 suites  252 💤
  1 files      0 ❌

Results for commit a31ed23.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 40m 1s ⏱️
5 183 tests 4 686 ✅ 497 💤 0 ❌
5 189 runs  4 686 ✅ 503 💤 0 ❌

Results for commit a31ed23.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   2h 2m 12s ⏱️ + 3m 54s
4 809 tests +2  4 472 ✅ +2  337 💤 ±0  0 ❌ ±0 
4 811 runs  +2  4 472 ✅ +2  339 💤 ±0  0 ❌ ±0 

Results for commit a31ed23. ± Comparison against base commit 9af2464.

@simonrw simonrw marked this pull request as ready for review October 8, 2025 15:47
pinzon
pinzon approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@simonrw simonrw merged commit c9f9602 into main Oct 8, 2025
60 checks passed
@simonrw simonrw deleted the cfn/fix-getatt-invalid-structure branch October 8, 2025 17:48
baermat pushed a commit that referenced this pull request Oct 13, 2025
@simonrw @baermat
CFn: handle invalid GetAtt validation (#13241)
989a2e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrw @pinzon