Skip to content

SNS: Fix multi-region test #13240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

SNS: Fix multi-region test #13240

merged 1 commit into from
Oct 8, 2025

Conversation

@baermat
Copy link
Member

@baermat baermat commented Oct 8, 2025 •
edited
Loading

Motivation

As per title. test_create_topic_in_multiple_regions was not very cleanly written in regards to multiple regions used. Additionally, the snapshots weren't transformed properly, causing flakes in the pipeline.
Context for the flakes: I am unsure what exactly triggers this, but essentially what happened was that only one region was transformed in the snapshots. And for the pipeline, it was "the other" region that was transformed, causing a mismatch.
MA/MR pipeline run can be found here

Changes

  • rewrite test_create_topic_in_multiple_regions

@baermat baermat self-assigned this Oct 8, 2025
@baermat baermat added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (MA/MR) - Preflight, Unit

22 298 tests   20 555 ✅  15m 7s ⏱️
     1 suites   1 743 💤
     1 files         0 ❌

Results for commit e1d1da7.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   16m 44s ⏱️ + 1m 17s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit e1d1da7. ± Comparison against base commit 8096cdf.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (MA/MR) - Alternative Providers

132 tests     9 ✅  24s ⏱️
  1 suites  123 💤
  1 files      0 ❌

Results for commit e1d1da7.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results - Alternative Providers

132 tests     9 ✅  24s ⏱️
  1 suites  123 💤
  1 files      0 ❌

Results for commit e1d1da7.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests   5 ✅  3m 20s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit e1d1da7.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit e1d1da7. ± Comparison against base commit 8096cdf.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   58m 52s ⏱️ - 1h 2m 7s
2 824 tests  - 1 983  2 711 ✅  - 1 759  113 💤  - 224  0 ❌ ±0 
2 826 runs   - 1 983  2 711 ✅  - 1 759  115 💤  - 224  0 ❌ ±0 

Results for commit e1d1da7. ± Comparison against base commit 8096cdf.

This pull request removes 1983 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

bentsku
bentsku approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I validated locally that the test works by setting the following environment variables: TEST_AWS_ACCESS_KEY_ID=745470033475, TEST_AWS_ACCOUNT_ID=745470033475, TEST_AWS_REGION_NAME=eu-west-1 and SECONDARY_TEST_AWS_REGION_NAME=ap-south-1 and it now passes 🥳

Not sure if we need to wait for the full MA/MR pipeline to be green, it takes quite a while 👍
Edit: it is already green 😄 and posted the results right under my comment

Thanks for fixing the test! and sorry for missing the hardcoded regions in the PR review

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files      5 suites   1h 27m 4s ⏱️
2 848 tests 2 738 ✅ 110 💤 0 ❌
2 854 runs  2 738 ✅ 116 💤 0 ❌

Results for commit e1d1da7.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 27m 44s ⏱️
2 848 tests 2 738 ✅ 110 💤 0 ❌
2 854 runs  2 738 ✅ 116 💤 0 ❌

Results for commit e1d1da7.

@baermat baermat marked this pull request as ready for review October 8, 2025 10:30
@baermat baermat merged commit 9af2464 into main Oct 8, 2025
79 of 82 checks passed
@baermat baermat deleted the sns/fix-multi-region-test branch October 8, 2025 10:30
baermat added a commit that referenced this pull request Oct 13, 2025
@baermat
SNS: Fix multi-region test (#13240)
b50a213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentsku bentsku bentsku approved these changes

Assignees

@baermat baermat

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baermat @bentsku