Skip to content

CFn: implement list change sets for new provider #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

CFn: implement list change sets for new provider #13149

merged 1 commit into from
Sep 17, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 16, 2025

Motivation

I was playing around with our local-surf extension trying to find missing pieces of the provider. I found that list_change_sets has not been migrated to the new provider so there were error messages.

Changes

  • Implement list-change-sets

@simonrw simonrw force-pushed the cfn/implement-list-change-sets branch from 869f220 to d653cd6 Compare September 16, 2025 14:55
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results - Preflight, Unit

22 145 tests  ±0   20 407 ✅ ±0   6m 20s ⏱️ -34s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d653cd6. ± Comparison against base commit 7a1d430.

@simonrw simonrw added aws:cloudformation AWS CloudFormation review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Sep 16, 2025
@simonrw simonrw added this to the 4.9 milestone Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 17s ⏱️ +11s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d653cd6. ± Comparison against base commit 7a1d430.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 31s ⏱️ - 1h 22m 30s
573 tests  - 4 097  458 ✅  - 3 880  115 💤  - 216  0 ❌  - 1 
575 runs   - 4 097  458 ✅  - 3 880  117 💤  - 216  0 ❌  - 1 

Results for commit d653cd6. ± Comparison against base commit 7a1d430.

This pull request removes 4098 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.test_change_sets ‑ test_list_change_sets

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   47m 24s ⏱️
597 tests 483 ✅ 114 💤 0 ❌
603 runs  483 ✅ 120 💤 0 ❌

Results for commit d653cd6.

@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results - Alternative Providers

572 tests   330 ✅  23m 42s ⏱️
  1 suites  242 💤
  1 files      0 ❌

Results for commit d653cd6.

@simonrw simonrw removed the request for review from dfangl September 16, 2025 15:44
pinzon
pinzon approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simonrw simonrw merged commit bb83964 into main Sep 17, 2025
57 of 59 checks passed
@simonrw simonrw deleted the cfn/implement-list-change-sets branch September 17, 2025 19:48
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrw @pinzon @alexrashed