S3: implement ObjectParts in GetObjectAttributes #12764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 49s ⏱️ Results for commit ea605bc. |
Test Results - Preflight, Unit21 621 tests 19 964 ✅ 6m 15s ⏱️ Results for commit ea605bc. |
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 8s ⏱️ Results for commit ea605bc. |
Test Results - Alternative Providers987 tests 589 ✅ 30m 35s ⏱️ Results for commit ea605bc. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 25m 9s ⏱️ Results for commit ea605bc. |
LocalStack Community integration with Pro 2 files 2 suites 1h 2m 12s ⏱️ Results for commit ea605bc. |
k-a-il
approved these changes
Jun 17, 2025
Contributor
k-a-il
left a comment
There was a problem hiding this comment.
LGTM, thank you for jumping on this issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported by #12757, we dit not return the full
ObjectPartsresponse in S3.The behavior is different if the checksum specified when creating the Multipart Upload with
CreateMultipartUploadis of typeCOMPOSITEorFULL_OBJECT. When it isCOMPOSITE, any call toGetObjectAttributeswith theObjectPartsattribute specified should act like aListPartscall.There was a TODO left about it, and this PR implements it.
It needed a change in API as we were not saving the metadata related to the Parts used to create the end object (we only store the data necessary to support
PartNumberinGetObject, via theget_part_rangefunction). This minor change in API is properly covered defensively to avoid issues when using this functionality (GetObjectwith thePartNumberparameter, or theGetObjectAttributescall) with a restored state from a previous version.Changes
GetObjectAttributeswithObjectPartsspecified