Bump moto-ext to 5.1.6.post2 #12760
Merged
Bump moto-ext to 5.1.6.post2 #12760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 58s ⏱️ Results for commit 6d77356. ♻️ This comment has been updated with latest results. |
alexrashed
reviewed
Jun 24, 2025
Member
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot for keeping moto(-ext) up to date! 💯
The changes are looking good to me, but I'll leave the final review to @dfangl since the only changes to a service provider is in IAM.
dfangl
approved these changes
Jun 24, 2025
Member
dfangl
left a comment
There was a problem hiding this comment.
I am not really happy with the snapshot ignores - this is strictly speaking, at least in part, a parity degradation after all, and we should follow up on this, by not including tags if they are not set at all.
For now this is fine for me though, to not hold back the merge 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps moto-ext to 5.1.6.post2
Contains:
Moto response serialiser is being reworked upstream where now the tags field in IAM resources is always returned. AWS does not return this field if no tags are set. This is causing snapshot tests to fail, because of which this PR marks the tags attribute to be skipped. This is expected to be resolved in future Moto releases. See getmoto/moto#8997.
To do