Skip to content

Conversation

@sorcerer-ares
Copy link
Contributor

This PR continues the modernization work started in #583 by updating the remaining Redis example manifests that are still using 'ReplicationController' in order to be up-to-date and maintain consistency. Deployment provides better rollout behavior, scaling, and self-healing.

Changes made:

  • Updated 'ReplicationController' to 'Deployment' in remaining yaml files (excluding legacy directory).
  • Added 'selectors.matchLabels' as required by Depolyment.
  • Verified on kind cluster locally, successfully created pods and deployments with correct number of replicas

Follow-up to: #583

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sorcerer-ares
Once this PR has been reviewed and has the lgtm label, please assign idvoretskyi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2025
@sorcerer-ares
Copy link
Contributor Author

/assign idvoretskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants