Adds a setting (default false) to use custom tray icon image #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi there, sorry for waiting so long for this PR, I was on vacation and recently get almost no time for developing ksnip. I like the idea of having this kind of customization :) I just had a brief look though the PR, more will hopefully come in next couple of days. Regarding the radio buttons, we usually have them vertically aligned, you have it now horizontally, any specific reason or could you place them vertically to be more inline with the remaining ones? Unit tests are run by the CI automatically. |
|
Is this a series of edits to be made to existing ksnip files to add this system tray functionality to a ksnip that previously did not have this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a setting to use a custom tray icon. It works with svgs, and I've got it set on my system now to use the same icon for ksnip from my icon pack.
New Settings
(note: ksnip doesn't seem to be able to take screenshots of it's own settings window so I had to use Spectacle, not sure if that's intentional or not)
Example custom icon
This is the first time I touched C++ since college, so if I did anything wrong let me know!
TODO: