Widget values as positional arguments #7260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
Author
|
ping @jdfreder @jasongrout @SylvainCorlay - I think we had decided that this made sense, but that's not recorded on #6566. |
Contributor
|
I'm taking a look... |
Contributor
|
Straight forward, looks good to me. 👍 |
Member
|
+1. The logic seem repeated. Should/Could it be moved to DOMWidget ? (does it make sens) |
Member
|
+1. I agree that in most cases, |
Contributor
This is what I originally suggested. @SylvainCorlay and I discussed it at the Bloomberg hackathon NY and he convinced me, because not all DOM widgets have value (even the builtin ones), it doesn't feel right to move it into the base. |
jdfreder
added a commit
that referenced
this pull request
Dec 18, 2014
Widget values as positional arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #6566 with a couple of fixes that have been holding it up from getting merged.