Make the widget warning brief and easy to filter #7204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this to not confuse the interactive user
Member
Author
|
ping @ellisonbg and @jdfreder, and I guess @minrk too, for a review. |
Member
|
Okay by me. I guess the disadvantage would be that the user may not know that widgets are being used, or they may not be used at all, possibly just an unused import in a library. Hiding the actual source of the warning makes it harder to find out what's going on. |
Member
Author
|
@minrk: I'm -0 on hiding the file/line number info for that reason. @ellisonbg seemed to want it, though, and I think he has a point about non-confusing messages. |
Member
|
Can you do a quick rebase on master? That should get the fixed warning test. |
Member
|
relaunched travis. |
Carreau
added a commit
that referenced
this pull request
Dec 15, 2014
Make the widget warning brief and easy to filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.