Allow widgets to be constructed from Javascript #6664

jdfreder · 2014-10-09T03:11:31Z

Also fixes a bug in the comm manager.

jdfreder · 2014-10-09T04:08:24Z

Based on #6665

jdfreder · 2014-10-09T15:07:38Z

@SylvainCorlay This https://github.com/ipython/ipython/pull/6664/files#diff-df42e22f1f926715f5932969a809e9f8R103 line is where you'd add logic to use the python registry you've made in your other PR.

jdfreder · 2014-10-09T23:01:13Z

For an example, see this notebook: http://nbviewer.ipython.org/gist/jdfreder/aee9b2079fc41ddbb81d

SylvainCorlay · 2014-10-09T23:29:05Z

This is really cool. Works nicely for me. Indeed, it would be nice if it used the backend registry.

SylvainCorlay · 2014-10-09T23:29:48Z

Should I rebase the backend registry on this and add the functionality?

jdfreder · 2014-10-09T23:51:57Z

I think you should wait to see which gets merged first. I'm fine rebasing on top of yours.

jdfreder · 2014-10-13T19:01:27Z

rebased

minrk · 2014-10-16T18:00:19Z

IPython/html/static/widgets/js/widget.js

= null or delete?

Both work in this context; however, I changed it to the later since your comment suggests that you prefer I use delete.

jdfreder · 2014-10-21T20:32:44Z

@minrk I addressed your review comments

jdfreder · 2014-10-22T18:18:26Z

@minrk @takluyver @ellisonbg @SylvainCorlay @jasongrout @Carreau anyone want to review this some more?

minrk · 2014-10-22T18:23:56Z

IPython/kernel/comm/manager.py

Probably don't want to silently eat them. Log it?

jdfreder · 2014-10-22T19:14:58Z

@minrk comments addressed and a test has been added

minrk · 2014-10-22T22:32:01Z

IPython/html/widgets/widget.py

Comms already have a primary bool that indicates whether they are the one that opens or is opened. Perhaps that should be relied upon here, rather than a duplicate flag that indicates the same information.

widget = widget_class(comm=comm)

Thanks for pointing this out. It turns out neither the open_comm or primary flags were needed here. 😄 Will ping back when removed...

takluyver · 2014-10-24T19:07:52Z

IPython/html/tests/widgets/manager.js

This is failing the tests on Python 3, because .values() returns an unordered view. You have a couple of options: list(Widget.widgets.values())[0], or next(iter(Widget.widgets.values())).

jdfreder · 2014-10-27T17:57:10Z

@takluyver @minrk comments addressed , thanks!

takluyver · 2014-10-27T23:56:22Z

IPython/html/widgets/widget.py

I would call this something more specific than target_name in the comm_open message, since it will now have content.target_name and content.data.target_name. How about widget_class?

jdfreder · 2014-10-28T00:59:24Z

@takluyver comments addressed

takluyver · 2014-10-28T01:22:04Z

Still having trouble with the JS tests on Travis:

In /home/travis/virtualenv/python3.4.1/lib/python3.4/site-packages/IPython/html/tests/widgets/manager.js:0

fail: Error running cell:

---------------------------------------------------------------------------

IndexError Traceback (most recent call last)

<ipython-input-1-df61df64d794> in <module>()

1 from IPython.html.widgets import Widget

----> 2 widget = list(Widget.widgets.values())[0]

3 print(widget.model_id)

IndexError: list index out of range

In /home/travis/virtualenv/python3.4.1/lib/python3.4/site-packages/IPython/html/tests/widgets/manager.js:0

uncaughtError: TypeError: 'undefined' is not an object (evaluating 'this.get_output_cell(index).text.trim')

Also added initial state push callback.

Also added a test!

jdfreder · 2014-10-29T00:59:57Z

Allow widgets to be constructed from Javascript

jdfreder · 2014-10-29T01:47:17Z

Thanks -not pinging- Thomas!

Allow widgets to be constructed from Javascript

ivanov added the -Needs review label Oct 9, 2014

jdfreder force-pushed the symmetric_widg branch from 4385e16 to 6e7c109 Compare October 9, 2014 03:12

jdfreder force-pushed the symmetric_widg branch from 7d28287 to 281801e Compare October 9, 2014 04:33

jdfreder force-pushed the symmetric_widg branch 2 times, most recently from c4138dd to 6e66012 Compare October 9, 2014 20:49

jdfreder added -Waiting for author and removed -Needs review labels Oct 13, 2014

jdfreder force-pushed the symmetric_widg branch from 6e66012 to cf7f734 Compare October 13, 2014 18:55

jdfreder added -Needs review and removed -Waiting for author labels Oct 13, 2014

jdfreder mentioned this pull request Oct 14, 2014

Creating a widget registry on the Python side. #6493

Merged

minrk force-pushed the master branch from 7cc431b to 5416279 Compare October 16, 2014 17:11

minrk reviewed Oct 16, 2014
View reviewed changes

minrk added -Waiting for author and removed -Needs review labels Oct 16, 2014

jdfreder added -Needs review and removed -Waiting for author labels Oct 21, 2014

jdfreder added the widgets label Oct 22, 2014

jdfreder added this to the 3.0 milestone Oct 22, 2014

minrk reviewed Oct 22, 2014
View reviewed changes

IPython/kernel/comm/manager.py Outdated

Copy link

Member

minrk Oct 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't want to silently eat them. Log it?

minrk reviewed Oct 22, 2014
View reviewed changes

jdfreder mentioned this pull request Oct 24, 2014

Widget persistence API #6789

Merged

2 tasks

takluyver reviewed Oct 24, 2014
View reviewed changes

takluyver reviewed Oct 27, 2014
View reviewed changes

jdfreder and others added 11 commits October 28, 2014 16:44

Enable widget instanciation from front-end.

4aec4bc

Make Python push initial state.

1161a7a

Also added initial state push callback.

Fixed typo.

39c0e0a

Rebase fixes.

3db8b05

Register the Widget target with the comm manager after construction.

37940ff

Address @minrk 's review comments.

ecc5739

Clarified API for the create_model function,

97e09c9

Also added a test!

Don't eat comm close error silently.

6b362cb

Address some more review comments...

4a597fb

s/target_name/widget_class

cd81e53

JS test fix

2916594

jdfreder force-pushed the symmetric_widg branch 3 times, most recently from d4ae3b6 to adfd377 Compare October 29, 2014 00:44

Rebase fixes

3dffe4a

jdfreder force-pushed the symmetric_widg branch from adfd377 to 3dffe4a Compare October 29, 2014 00:55

takluyver added a commit that referenced this pull request Oct 29, 2014

Merge pull request #6664 from jdfreder/symmetric_widg

8955317

Allow widgets to be constructed from Javascript

takluyver merged commit 8955317 into ipython:master Oct 29, 2014

ivanov removed the -Needs review label Oct 29, 2014

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request ipython#6664 from jdfreder/symmetric_widg

4250292

Allow widgets to be constructed from Javascript

Uh oh!

Allow widgets to be constructed from Javascript #6664

Allow widgets to be constructed from Javascript #6664

Uh oh!

Conversation

jdfreder commented Oct 9, 2014

Uh oh!

jdfreder commented Oct 9, 2014

Uh oh!

jdfreder commented Oct 9, 2014

Uh oh!

jdfreder commented Oct 9, 2014

Uh oh!

SylvainCorlay commented Oct 9, 2014

Uh oh!

SylvainCorlay commented Oct 9, 2014

Uh oh!

jdfreder commented Oct 9, 2014

Uh oh!

jdfreder commented Oct 13, 2014

Uh oh!

minrk Oct 16, 2014

Choose a reason for hiding this comment

Uh oh!

jdfreder Oct 21, 2014

Choose a reason for hiding this comment

Uh oh!

jdfreder commented Oct 21, 2014

Uh oh!

jdfreder commented Oct 22, 2014

Uh oh!

minrk Oct 22, 2014

Choose a reason for hiding this comment

Uh oh!

jdfreder commented Oct 22, 2014

Uh oh!

minrk Oct 22, 2014

Choose a reason for hiding this comment

Uh oh!

jdfreder Oct 27, 2014

Choose a reason for hiding this comment

Uh oh!

takluyver Oct 24, 2014

Choose a reason for hiding this comment

Uh oh!

jdfreder commented Oct 27, 2014

Uh oh!

takluyver Oct 27, 2014

Choose a reason for hiding this comment

Uh oh!

jdfreder commented Oct 28, 2014

Uh oh!

takluyver commented Oct 28, 2014

Uh oh!

jdfreder commented Oct 29, 2014

Uh oh!

jdfreder commented Oct 29, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants