Add the Security Group for Virtual IP #3497
Conversation
mandre
left a comment
There was a problem hiding this comment.
This needs modification of the acceptance tests to show this feature is working as intended.
You would have to ensure the vip_sg_ids parameter is set only in newer versions of OpenStack as this is a new feature of the 2025.1 release.
| VipQosPolicyID string `json:"vip_qos_policy_id,omitempty"` | ||
|
|
||
| // The ID of the Security Group which will apply to the Virtual IP | ||
| VipSecGroupID string `json:"vip_sg_id,omitempty"` |
There was a problem hiding this comment.
Both the linked spec and the docs say the parameter is called vip_sg_ids in plural form. A look at the code also confirms this needs to be plural.
| // The ID of the QoS Policy which will apply to the Virtual IP | ||
| VipQosPolicyID string `json:"vip_qos_policy_id,omitempty"` | ||
|
|
||
| // The ID of the Security Group which will apply to the Virtual IP |
There was a problem hiding this comment.
Please document the minimum API version for this parameter (2.29 according to the docs), that came with OpenStack 2025.1.
| VipQosPolicyID *string `json:"vip_qos_policy_id,omitempty"` | ||
|
|
||
| // The ID of the Security Group which will apply to the Virtual IP | ||
| VipSecGroupID string `json:"vip_sg_id,omitempty"` |
There was a problem hiding this comment.
Please also add acceptance tests showing that you can clear existing VIP security groups with the Update call.
Support for Custom Security Groups for VIP Ports
https://github.com/openstack/octavia/blob/00599cb91ce9b5ab80119e329845e54f6e1e0a10/specs/version15.0/custom-security-groups-for-VIP-ports.rst#L168