Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

docs: add a code sample using bpd.options.bigquery.ordering_mode = "partial"#909

Merged
tswast merged 12 commits intomainfrom
tswast-ordering-mode-partial-sample
Nov 25, 2024
Merged

docs: add a code sample using bpd.options.bigquery.ordering_mode = "partial"#909
tswast merged 12 commits intomainfrom
tswast-ordering-mode-partial-sample

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Aug 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal code change 662899733 🦕

@tswast tswast requested a review from a team as a code owner August 21, 2024 15:29
@tswast tswast requested review from a team, TrevorBergeron and ohmayr August 21, 2024 15:29
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Aug 21, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Aug 21, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 21, 2024
@tswast tswast requested a review from chelsea-lin October 25, 2024 17:06
@tswast tswast merged commit f80d705 into main Nov 25, 2024
@tswast tswast deleted the tswast-ordering-mode-partial-sample branch November 25, 2024 19:32
@release-please release-please bot mentioned this pull request Nov 25, 2024
Merged
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Nov 25, 2024

Oops. I merged too soon. #1173 to fix the failing Samples tests.

Since it was only remote function and llm that were failures, I (incorrectly) assumed those were flakes.

@GarrettWu GarrettWu mentioned this pull request Nov 25, 2024
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ohmayr ohmayr Awaiting requested review from ohmayr ohmayr is a code owner automatically assigned from googleapis/python-samples-reviewers

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

1 more reviewer

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @chelsea-lin @shobsi