Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: Fewer relation joins from df self-operations#823

Merged
TrevorBergeron merged 6 commits intomainfrom
better_implicit_joiner
Jul 11, 2024
Merged

fix: Fewer relation joins from df self-operations#823
TrevorBergeron merged 6 commits intomainfrom
better_implicit_joiner

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 4, 2024
@TrevorBergeron TrevorBergeron force-pushed the better_implicit_joiner branch from 93f1733 to fc17398 Compare July 4, 2024 02:28
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 4, 2024 02:28
@TrevorBergeron TrevorBergeron requested review from a team and Genesis929 July 4, 2024 02:28
Comment thread tests/system/small/test_dataframe.py Outdated
import bigframes._config.display_options as display_options
import bigframes.core.indexes as bf_indexes
import bigframes.dataframe as dataframe
import bigframes.pandas
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems import not used and maybe duplicated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in new revision

@TrevorBergeron TrevorBergeron merged commit 0d24f73 into main Jul 11, 2024
@TrevorBergeron TrevorBergeron deleted the better_implicit_joiner branch July 11, 2024 01:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants