Conversation
e61ddcd to
20587eb
Compare
| uid: bigframes.ml.remote.VertexAIModel | ||
| name: remote | ||
| name: bigframes.ml | ||
| - name: Bigquery Built-in Functions |
There was a problem hiding this comment.
I think the structure is wrong here? It should be parallel with bigframes.ml, bigframes.pandas and start with - items, and we want to name it bigframes.bigquery or Bigquery Built-in Functions?
You can run nox -s docfx to see if it can generate the page for you:
https://g3doc.corp.google.com/devrel/cloud/infra/devrel_services/g3doc/dev/content_automation/cloud_rad/python.md?cl=head#staging-local-changes-from-github-to-devsite to stage docs manually.
There was a problem hiding this comment.
Good catch! It should be fixed. Also check the generated docs from this change: https://bigframes-swe.teams.x20web.corp.google.com/chelsealin/bigframes-docs-2024-04-22/reference/bigframes.bigquery/index.html
TrevorBergeron
left a comment
There was a problem hiding this comment.
Lets fix the spelling in the PR title as well
bigframes.bigquery sub-package and adds bigframes.bigquery.array_length function
0872885 to
5a2c2e8
Compare
bigframes.bigquery sub-package and adds bigframes.bigquery.array_length functionbigframes.bigquery sub-package with a bigframes.bigquery.array_length function
|
e2e failure: |
| name: remote | ||
| name: bigframes.ml | ||
| - items: | ||
| - name: Bigquery Built-in Functions |
tswast
left a comment
There was a problem hiding this comment.
Thanks so much, love it! This is a big milestone and will allow for future expansion of BigQuery SQL APIs, including those without a direct analogue to pandas methods.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕