Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: add ml.preprocessing.LabelEncoder#50

Merged
ashleyxuu merged 1 commit intomainfrom
ashleyxu-add-label-encoder
Sep 22, 2023
Merged

feat: add ml.preprocessing.LabelEncoder#50
ashleyxuu merged 1 commit intomainfrom
ashleyxu-add-label-encoder

Conversation

@ashleyxuu
Copy link
Copy Markdown
Contributor

@ashleyxuu ashleyxuu commented Sep 21, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu ashleyxuu requested review from a team September 21, 2023 23:48
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 21, 2023
@ashleyxuu ashleyxuu added kokoro:run Add this label to force Kokoro to re-run the tests. and removed api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 22, 2023
GarrettWu
GarrettWu reviewed Sep 22, 2023
View reviewed changes
Comment thread bigframes/ml/sql.py
Comment thread bigframes/ml/pipeline.py Outdated
Comment thread tests/system/large/ml/test_pipeline.py
Comment thread third_party/bigframes_vendored/sklearn/preprocessing/_label.py Outdated
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 22, 2023
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-label-encoder branch from 05eef21 to a33a66e Compare September 22, 2023 17:20
@bigframes-bot bigframes-bot removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 22, 2023
@ashleyxuu ashleyxuu merged commit 2510461 into main Sep 22, 2023
@ashleyxuu ashleyxuu deleted the ashleyxu-add-label-encoder branch September 22, 2023 18:50
@release-please release-please bot mentioned this pull request Sep 22, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GarrettWu GarrettWu GarrettWu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GarrettWu GarrettWu

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashleyxuu @GarrettWu @shobsi @bigframes-bot