Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: DF.drop tuple input as multi-index#301

Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom
garrettwu-drop
Jan 5, 2024
Merged

fix: DF.drop tuple input as multi-index#301
gcf-merge-on-green[bot] merged 5 commits intomainfrom
garrettwu-drop

Conversation

@GarrettWu
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/317131784

@GarrettWu GarrettWu requested review from a team, TrevorBergeron and shobsi January 3, 2024 22:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 3, 2024
Comment thread tests/system/small/test_multiindex.py Outdated
bf_result = bf_frame.drop(labels=labels, axis="index", level=level).to_pandas()
pd_result = pd_frame.drop(labels=labels, axis="index", level=level)

print("over")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray print

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you caught me :)

Comment thread bigframes/dataframe.py
@GarrettWu GarrettWu requested a review from shobsi January 4, 2024 19:24
@GarrettWu GarrettWu added the automerge Merge the pull request once unit tests and other checks pass. label Jan 5, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 21391a9 into main Jan 5, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the garrettwu-drop branch January 5, 2024 01:00
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants