Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

perf: Prevent inlining of remote ops#1347

Merged
TrevorBergeron merged 1 commit intomainfrom
no_inline
Feb 3, 2025
Merged

perf: Prevent inlining of remote ops#1347
TrevorBergeron merged 1 commit intomainfrom
no_inline

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

@TrevorBergeron TrevorBergeron commented Jan 31, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 31, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 31, 2025
@TrevorBergeron TrevorBergeron requested a review from shobsi January 31, 2025 22:30
@TrevorBergeron TrevorBergeron marked this pull request as ready for review January 31, 2025 22:30
@TrevorBergeron TrevorBergeron requested review from a team January 31, 2025 22:30
@tswast
Copy link
Copy Markdown
Contributor

tswast commented Feb 3, 2025

@TrevorBergeron Can you please provide some more context around this change?

@TrevorBergeron
Copy link
Copy Markdown
Contributor Author

TrevorBergeron commented Feb 3, 2025

@TrevorBergeron Can you please provide some more context around this change?

Basically, remote functions were being merged into subsequent selects, possibly inlining multiple times into different references. This was causing the SQL engine to call the remote function with duplicate calls. This change stops us from inlining remote function op SQL.

@TrevorBergeron TrevorBergeron merged commit 012081a into main Feb 3, 2025
@TrevorBergeron TrevorBergeron deleted the no_inline branch February 3, 2025 19:24
@release-please release-please bot mentioned this pull request Feb 3, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shobsi shobsi shobsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rey-esp rey-esp

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrevorBergeron @tswast @shobsi @rey-esp