Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: support time_series_id_col in ARIMAPlus #1282

Merged
shuoweil merged 10 commits intomainfrom
shuowei-arima-plus
Jan 28, 2025
Merged

feat: support time_series_id_col in ARIMAPlus #1282
shuoweil merged 10 commits intomainfrom
shuowei-arima-plus

Conversation

@shuoweil
Copy link
Copy Markdown
Contributor

@shuoweil shuoweil commented Jan 11, 2025

feat: support time_series_id_col in ARIMAPlus,
(1) introduce time_series_id_col as an optional input feature, user needs to specific which column is used as time_series_id_col.
(2) update all testcases to test the original ARIMA plus model (without id_col) and new ARIMA plus model (with id_col).
(3) for generality test, expand the input dataset to include multiple ids for the same date

@shuoweil shuoweil requested a review from GarrettWu January 11, 2025 02:52
@shuoweil shuoweil self-assigned this Jan 11, 2025
@shuoweil shuoweil requested review from a team January 11, 2025 02:52
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 11, 2025
@shuoweil shuoweil enabled auto-merge (squash) January 11, 2025 02:52
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2025
@shuoweil shuoweil requested a review from tswast January 13, 2025 18:55
Comment thread tests/system/conftest.py Outdated
Comment thread bigframes/ml/core.py Outdated
Comment thread bigframes/ml/core.py Outdated
Comment thread bigframes/ml/forecasting.py Outdated
@shuoweil shuoweil requested a review from a team as a code owner January 20, 2025 01:26
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Jan 20, 2025

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@shuoweil shuoweil closed this Jan 20, 2025
auto-merge was automatically disabled January 20, 2025 01:34

Pull request was closed

@shuoweil shuoweil reopened this Jan 20, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 20, 2025
@shuoweil shuoweil requested review from GarrettWu and removed request for a team and msampathkumar January 20, 2025 01:52
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jan 20, 2025
@shuoweil shuoweil closed this Jan 20, 2025
@shuoweil shuoweil reopened this Jan 20, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Jan 20, 2025
@shuoweil shuoweil enabled auto-merge (squash) January 20, 2025 04:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: l Pull request size is large. and removed size: xl Pull request size is extra large. size: m Pull request size is medium. labels Jan 24, 2025
@shuoweil shuoweil disabled auto-merge January 24, 2025 20:53
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 24, 2025
@shuoweil shuoweil requested a review from GarrettWu January 24, 2025 23:15
@shuoweil shuoweil enabled auto-merge (squash) January 24, 2025 23:15
Comment thread bigframes/ml/forecasting.py Outdated
Comment thread bigframes/ml/forecasting.py
Comment thread bigframes/ml/forecasting.py
Comment thread tests/system/small/ml/test_core.py Outdated
@shuoweil shuoweil requested a review from GarrettWu January 28, 2025 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants