Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: Update llm.TextEmbeddingGenerator to 005#1186

Merged
shuoweil merged 7 commits intomainfrom
shuowei-update-textembedding005
Dec 6, 2024
Merged

feat: Update llm.TextEmbeddingGenerator to 005#1186
shuoweil merged 7 commits intomainfrom
shuowei-update-textembedding005

Conversation

@shuoweil
Copy link
Copy Markdown
Contributor

@shuoweil shuoweil commented Dec 3, 2024

Update llm.TextEmbeddingGenerator to 005, update feature, docs, and tests. The default value is reamined as text-embedding-004 for better customer experience.

Bug: 381935784

@shuoweil shuoweil requested a review from GarrettWu December 3, 2024 21:32
@shuoweil shuoweil self-assigned this Dec 3, 2024
@shuoweil shuoweil requested review from a team December 3, 2024 21:32
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 3, 2024
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2024
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
Copy link
Copy Markdown
Contributor

@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


>>> import bigframes.ml.llm as llm
>>> model = llm.TextEmbeddingGenerator(model_name="text-embedding-004")
>>> model = llm.TextEmbeddingGenerator(model_name="text-embedding-005")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs tests fail on semantic. These changes are unnecessary. Maybe just revert it.

@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2024
@shuoweil shuoweil merged commit 3072d38 into main Dec 6, 2024
@shuoweil shuoweil deleted the shuowei-update-textembedding005 branch December 6, 2024 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants