Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: add ARIMAPlus.predict_explain() to generate forecasts with explanation columns #1177

Merged
tswast merged 28 commits intomainfrom
ml-predict-explain
Dec 9, 2024
Merged

feat: add ARIMAPlus.predict_explain() to generate forecasts with explanation columns #1177
tswast merged 28 commits intomainfrom
ml-predict-explain

Conversation

@rey-esp
Copy link
Copy Markdown
Contributor

@rey-esp rey-esp commented Nov 26, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 26, 2024
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 26, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Nov 26, 2024
@chelsea-lin
Copy link
Copy Markdown
Contributor

The debug.ipynb is not expected to be pushed. Hence, I reverted this commit through git revert f6dd455. Thjanks @rey-esp

@chelsea-lin
Copy link
Copy Markdown
Contributor

To fix lint tests, please run nox -r -s format and then run nox -r -s lint lint_setup_py commands. They can automatically format codes and check lint.

@chelsea-lin chelsea-lin changed the title feat: add predict_explain() and predict_forecast() feat: add ARIMAPlus.predict_explain() to generate forecasts with explanation columns Nov 26, 2024
@rey-esp rey-esp marked this pull request as ready for review November 26, 2024 20:21
@rey-esp rey-esp requested review from a team November 26, 2024 20:21
Comment thread bigframes/ml/forecasting.py Outdated
Comment thread bigframes/ml/forecasting.py
Comment thread tests/system/small/ml/test_forecasting.py Outdated
rey-esp and others added 3 commits December 2, 2024 09:56
"seasonal_period_daily",
"holiday_effect",
}
assert expected_columns <= prediction_columns
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
Copy link
Copy Markdown
Contributor

tswast commented Dec 9, 2024

doctest failures is FAILED bigframes/operations/semantics.py::bigframes.operations.semantics.Semantics.sim_join and appears unrelated.

@tswast tswast enabled auto-merge (squash) December 9, 2024 23:01
@tswast tswast merged commit 05f8b4d into main Dec 9, 2024
@tswast tswast deleted the ml-predict-explain branch December 9, 2024 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants