Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: show warning for unknown location set through .ctor#1052

Merged
shobsi merged 5 commits intomainfrom
shobs-location-warning-session
Oct 7, 2024
Merged

fix: show warning for unknown location set through .ctor#1052
shobsi merged 5 commits intomainfrom
shobs-location-warning-session

Conversation

@shobsi
Copy link
Copy Markdown
Contributor

@shobsi shobsi commented Oct 4, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 371205929 🦕

@shobsi shobsi requested review from a team and TrevorBergeron October 4, 2024 22:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 4, 2024
@shobsi shobsi requested a review from Genesis929 October 7, 2024 23:39
@shobsi shobsi merged commit 02c2da7 into main Oct 7, 2024
@shobsi shobsi deleted the shobs-location-warning-session branch October 7, 2024 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants