Skip to content

Conversation

@GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Feb 24, 2025

Gem Updates

This pull request updates all Ruby Gems in this project with bundle update. I started off on this PR with the goal of resolving two dependabot alerts related to nokogiri and kept going from there.

This PR also does the following:

Ruby 3.0 EOL

These changes also remove Ruby 3.0 from the test suite as it has gone EOL as of 2024-04-23

Extend CI to cover Ruby 3.4

These changes add Ruby 3.4 to the test suite as it is the latest version of Ruby and we should ensure the test suite can run against it successfully (it does 😄).

Bump the .ruby-version and bundler

These changes also bump the local dev version of Ruby that is used to 3.4.2 and the bundler version to 2.6.5. Both of these are the latest versions at this time of writing.


Related: https://github.com/github/rubocop-github/security/dependabot/45, https://github.com/github/rubocop-github/security/dependabot/44

@GrantBirki GrantBirki added the dependencies Pull requests that update a dependency file label Feb 24, 2025
Copilot AI review requested due to automatic review settings February 24, 2025 21:58
@GrantBirki GrantBirki requested a review from a team as a code owner February 24, 2025 21:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates all Ruby Gems in the project using "bundle update" and addresses a duplicate configuration entry in the gemspec.

  • Added the required Ruby version setting earlier in the file.
  • Removed the duplicated setting later in the file.

Reviewed Changes

File Description
rubocop-github.gemspec Added a required Ruby version line at the start and removed a duplicate later in the file.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link
Contributor

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take out the version bump and let the maintainers decide when (and what) the next release will be.

Copy link
Contributor

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@GrantBirki GrantBirki merged commit fb9a32c into main Feb 25, 2025
10 checks passed
@GrantBirki GrantBirki deleted the gem-updates branch February 25, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants