Add new a11y rubocop rule: NoPositiveTabindex

Adrián Bolonio · Adrián Bolonio · commit bb358f2c9b69 · 2022-07-28T14:20:58.000Z
diff --git a/lib/rubocop/cop/github/rails_no_positive_tabindex.rb b/lib/rubocop/cop/github/rails_no_positive_tabindex.rb
@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class NoPositiveTabindex < Base
+          MSG = "Positive tabindex is error-prone and often inaccessible."
+
+          def on_send(node)
+            receiver, method_name, *args = *node
+            if receiver.nil?
+              args.select do |arg|
+                arg.type == :hash
+              end.each do |hash|
+                hash.each_pair do |key, value|
+                  next if key.type == :dsym
+                  next unless key.respond_to?(:value)
+                  if key.value == :tabindex && value.source.to_i > 0
+                    add_offense(hash)
+                  end
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/test_rails_no_positive_tabindex.rb b/test/test_rails_no_positive_tabindex.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/rails_no_positive_tabindex"
+
+class NoPositiveTabindex < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::NoPositiveTabindex
+  end
+
+  def test_no_positive_tabindex_alt_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= button_tag "Continue", :tabindex => 3 %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Positive tabindex is error-prone and often inaccessible.", offenses[0].message
+  end
+
+  def test_no_positive_tabindex_alt_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+       <%= button_tag "Continue", :tabindex => -1 %>
+    ERB
+    
+    assert_equal 0, offenses.count
+  end
+end
