feat!: make processing interface async #1920
Open
+60
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes the processor interface to be async. Instead of
VideoFrame onFrame(VideoFrame frame), which requires to process the frame immediately on the current thread, basing the interface on theVideoSinkinterface allows dispatching frame processing to thread pools, GPU etc.The new interface requires two functions:
void setSink(VideoSink videoSink)which provides a processor with the next processor or a final sink/renderer which is should forward processed frames to. If it is null, neither processing nor forwarding is neededvoid onFrame(VideoFrame frame)(fromVideoSink), which tells the processor about a new frame. Depending on the current workload (FPS, previous frame still processing, etc), the processor can chose to ignore the frame or process it.The change is done in a similar way on iOS
There might be a way to make this backwards compatible with older, synchronous implementations of the interface. If there is a chance that this is merged, I can look into it