refactor(predictions): update deprecated remote config functions #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into rpf-update-predictions-snippets
thatfiredev
commented
Feb 7, 2020
|
|
||
| public class ConditionalAdsActivity extends AppCompatActivity { | ||
|
|
||
| private static final long CACHE_EXPIRATION = 60 * 1000; |
Member
Author
There was a problem hiding this comment.
Note to reviewer: This constant was being passed as argument to the (now deprecated) fetch() function. The new fetchAndActivate() function doesn't require it, since fetch interval should now be specified while configuring Remote Config.
| final FirebaseRemoteConfig config = FirebaseRemoteConfig.getInstance(); | ||
|
|
||
| Map remoteConfigDefaults = new HashMap<String, Object>(); | ||
| Map<String, Object> remoteConfigDefaults = new HashMap<>(); |
Member
Author
There was a problem hiding this comment.
Note to reviewer: Made this change to keep it consistent with the other snippets.
Contributor
|
@rosariopfernandes LGTM and thank you for the reviewer notes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #171 , but now in our Firebase Predictions snippets.