Buf write simplification #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe63372 to
af01457
Compare
cburgdorf
approved these changes
Jun 19, 2023
af01457 to
b67e25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The buf write implementation seems unnecessarily complicated.
Currently we allocate the exact
lenin memory for the buffer and ensure viarewrite_slotthat we do not modify data outside of the buf's allocated region.This PR changes the buf implementation so that an extra 31 bytes is allocated for bufs. This eliminates the need for a function like
rewrite_slot.How was it fixed?
⌨️
To-Do