fix: Use original plugin from disk in FlatCompat #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like there's currently a problem with the GitHub CI services as it can't download Node.js. Will try re-running jobs in a bit. |
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
CI works now. Looks good, aside from one detail.
ljharb
reviewed
Nov 27, 2023
Comment on lines
+112
to
+113
| definition: _ignore1, // eslint-disable-line no-unused-vars | ||
| original: _ignore2, // eslint-disable-line no-unused-vars |
Contributor
There was a problem hiding this comment.
Seems like https://eslint.org/docs/latest/rules/no-unused-vars#varsignorepattern could be useful here, and then you can do something like
Suggested change
| definition: _ignore1, // eslint-disable-line no-unused-vars | |
| original: _ignore2, // eslint-disable-line no-unused-vars | |
| definition: _, | |
| original: __, |
Member
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches
FlatCompatto use the original (unnormalized) version of the plugin that was loaded from disk rather than the normalized version. This ensures that we'll avoid plugin redefinition errors when folks are using bothFlatCompatand their own imports.Fixes #135