feat: update error loc of require-yield and no-useless-constructor
#20267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
requested changes
Nov 2, 2025
Member
lumirlumir
left a comment
There was a problem hiding this comment.
Personally, I like this change to make the rules less visually disruptive. 👍
I've left some comments throughout. If any of my suggestions are incorrect, please let me know!
lumirlumir
approved these changes
Nov 4, 2025
Member
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like another review before merging.
Contributor
|
The release monitor said no patch release is pending. But I see 10.0.0-alpha.0 was just released, so I hope it's okay that this PR was merged? 
|
Member
It's ok, we can merge new changes after prereleases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated the error location of
require-yieldandno-useless-constructorto make them less visually disruptive. Similar rulerequire-yield,require-awaitalso highlight function head.Is there anything you'd like reviewers to focus on?
Similar to #20258