-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat!: replace chalk with styleText and add color to ResultsMeta
#20227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace chalk with styleText and add color to ResultsMeta
#20227
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
This comment was marked as resolved.
This comment was marked as resolved.
|
it's unblocked as #20160 has been merged. |
|
Will there be any changes in the output of the |
|
Thanks everyone for the reviews! Once I've finished all my work, I'll mark the PR as ready instead of draft. |
20c0c6c to
99a41c6
Compare
8584fc3 to
ce8b860
Compare
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
…ttps://github.com/eslint/eslint into refactor-replace-chalk-with-nodejs-native-styletext
c54d5e7 to
3133712
Compare
lumirlumir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've resolved all of the comments.
Another pair of eyes on it would be helpful!
mdjermanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for @fasttime to verify.
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
In this PR, I've migrated from the external
chalklibrary to Node.js's nativestyleText.This PR closes the issue mentioned in #20012.
Is there anything you'd like reviewers to focus on?
Closes: #20012