Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Oct 20, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

In this PR, I've migrated from the external chalk library to Node.js's native styleText.

This PR closes the issue mentioned in #20012.

Is there anything you'd like reviewers to focus on?

Closes: #20012

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 20, 2025
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit e214cd4
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/693addc4c90eed0008ea9916

@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible bug ESLint is working incorrectly labels Oct 20, 2025
@github-actions github-actions bot added cli Relates to ESLint's command-line interface formatter Relates to the formatters bundled with ESLint labels Oct 20, 2025
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Oct 22, 2025
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the Stale label Nov 3, 2025
@aladdin-add aladdin-add removed the Stale label Nov 4, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 4, 2025
@aladdin-add
Copy link
Member

it's unblocked as #20160 has been merged.

@mdjermanovic
Copy link
Member

Will there be any changes in the output of the stylish formatter? If not, then since this by itself wouldn't be a breaking change perhaps we could tag it as just refactor.

@lumirlumir
Copy link
Member Author

Thanks everyone for the reviews! Once I've finished all my work, I'll mark the PR as ready instead of draft.

@lumirlumir lumirlumir force-pushed the refactor-replace-chalk-with-nodejs-native-styletext branch from 20c0c6c to 99a41c6 Compare November 7, 2025 14:33
@lumirlumir lumirlumir force-pushed the refactor-replace-chalk-with-nodejs-native-styletext branch from 8584fc3 to ce8b860 Compare December 10, 2025 13:05
@mdjermanovic mdjermanovic removed the tsc waiting Issues that require feedback from a TSC member label Dec 10, 2025
@lumirlumir lumirlumir force-pushed the refactor-replace-chalk-with-nodejs-native-styletext branch from c54d5e7 to 3133712 Compare December 11, 2025 09:01
Copy link
Member Author

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've resolved all of the comments.

Another pair of eyes on it would be helpful!

@lumirlumir lumirlumir marked this pull request as ready for review December 11, 2025 09:26
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @fasttime to verify.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Dec 11, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit a176319 into main Dec 11, 2025
36 checks passed
@fasttime fasttime deleted the refactor-replace-chalk-with-nodejs-native-styletext branch December 11, 2025 20:07
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible cli Relates to ESLint's command-line interface feature This change adds a new feature to ESLint formatter Relates to the formatters bundled with ESLint

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Change Request: Replace chalk with Node.js' native styleText in v10

7 participants