fix: do not resolve electron entrypoints on disk (#39248)

trop[bot] · MarshallOfSound · jkleinsc · web-flow · commit 878f18474e92 · 2023-07-27T12:57:21.000-07:00
* fix: do not resolve electron entrypoints on disk

Co-authored-by: Samuel Attard &lt;marshallofsound@electronjs.org&gt;

* chore: fixup .patches file after trop

---------

Co-authored-by: trop[bot] &lt;37223003+trop[bot]@users.noreply.github.com&gt;
Co-authored-by: Samuel Attard &lt;marshallofsound@electronjs.org&gt;
Co-authored-by: John Kleinschmidt &lt;jkleinsc@electronjs.org&gt;
diff --git a/patches/node/.patches b/patches/node/.patches
@@ -55,3 +55,4 @@ chore_enable_c_17_for_native_modules.patch
 enable_crashpad_linux_node_processes.patch
 cherry-pick-09ae62b.patch
 allow_embedder_to_control_codegenerationfromstringscallback.patch
+fix_do_not_resolve_electron_entrypoints.patch
diff --git a/patches/node/fix_do_not_resolve_electron_entrypoints.patch b/patches/node/fix_do_not_resolve_electron_entrypoints.patch
@@ -0,0 +1,24 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Samuel Attard <marshallofsound@electronjs.org>
+Date: Wed, 26 Jul 2023 17:03:15 -0700
+Subject: fix: do not resolve electron entrypoints
+
+This wastes fs cycles and can result in strange behavior if this path actually exists on disk
+
+diff --git a/lib/internal/modules/run_main.js b/lib/internal/modules/run_main.js
+index 5a50d5d6afab6e6648f72a1c0efa1df4cd80bcd9..0be45309028b00a6957ee473322a9452a7fa7d67 100644
+--- a/lib/internal/modules/run_main.js
++++ b/lib/internal/modules/run_main.js
+@@ -13,6 +13,12 @@ const {
+ } = require('internal/modules/esm/handle_process_exit');
+ 
+ function resolveMainPath(main) {
++  // For built-in modules used as the main entry point we _never_
++  // want to waste cycles resolving them to file paths on disk
++  // that actually might exist
++  if (typeof main === 'string' && main.startsWith('electron/js2c')) {
++    return main;
++  }
+   // Note extension resolution for the main entry point can be deprecated in a
+   // future major.
+   // Module._findPath is monkey-patchable here.
