This repository was archived by the owner on Jul 14, 2025. It is now read-only.
UX: category-id-input: allows no-category selection #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
reviewed
Jun 3, 2025
jjaffeux
reviewed
Jun 3, 2025
jjaffeux
reviewed
Jun 4, 2025
Contributor
jjaffeux
left a comment
There was a problem hiding this comment.
Where do we test it's actually nullable? I dont see a test using "no category"
This commit includes DRY update: by adding getSearchParam func
Contributor
Author
Good observation, thanks! I added the assert in 257f603 |
jjaffeux
approved these changes
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue logged in https://meta.discourse.org/t/category-id-dropdowns-in-data-explorer-cannot-be-cleared/362370/.
Implementation Details
The
category_idparameter now includes the (no category) option, which allows clearing a previously selected category.The (no category) option is selected by default.
NOTE:
It is important to include
nullprefix when defining a nullablecategory_idquery parameter. Detailed instructions are defined in https://meta.discourse.org/t/utilizing-parameters-in-data-explorer-queries/277934#p-1361177-null-parameters-11.