Skip to content

Salt with 31 rounds is insecure because of bitwise shift #25

@tanertopal

Description

@tanertopal

The salt with 31 rounds is insecure. The bitwise shift here:

rounds = 1 << rounds;

Will result in -2147483648 not 2147483648. So this:
https://github.com/dcodeIO/bcrypt.js/blob/d5d46150e9da7d15d3f70fd97649e923d95013af/src/bcrypt/impl.js
will never run.

Pull request #24

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions