Skip to content

fix memory leak in app header #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix memory leak in app header #451

merged 1 commit into from
Oct 29, 2025
+4 −2

Conversation

@codomposer
Copy link
Contributor

@codomposer codomposer commented Oct 29, 2025 •
edited
Loading

Fix: Issue 450

Fixes #113
Fixes #268
Fixes #329

Problem

The scroll event listener in AppHeader was never cleaned up, causing memory leaks on component unmount.

Solution

Added cleanup function to remove the event listener when component unmounts.

Changes

  • Extracted inline arrow function to named handleScroll function
  • Added return statement in useEffect to remove listener on unmount

Code

useEffect(() => {
  const handleScroll = () => {
    headerRef.current &&
      headerRef.current.classList.toggle('shadow-sm', document.documentElement.scrollTop > 0)
  }
  document.addEventListener('scroll', handleScroll)
  return () => document.removeEventListener('scroll', handleScroll)
}, [])

@mrholek mrholek merged commit 145e651 into coreui:main Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSidebar auto-collapses on clicking on the panel in React app Asking modify sidebar Login router problem

2 participants

@codomposer @mrholek