fix: return undefined instead of throw error upon missing pageContext (fix vikejs/vike-react#147)

brillout · brillout · commit 103f30b57c97 · 2024-09-06T10:02:15.000+02:00
diff --git a/packages/vike-vue/src/hooks/useData.ts b/packages/vike-vue/src/hooks/useData.ts
@@ -9,8 +9,7 @@ const key = 'vike-vue:useData'
 
 /** https://vike.dev/useData */
 function useData<Data>(): ShallowReactive<Data> {
-  const data = inject<ShallowReactive<Data>>(key)
-  if (!data) throw new Error('setData() not called')
+  const data = inject<ShallowReactive<Data>>(key)!
   return data
 }
 
diff --git a/packages/vike-vue/src/hooks/usePageContext.ts b/packages/vike-vue/src/hooks/usePageContext.ts
@@ -10,8 +10,7 @@ const key = 'vike-vue:usePageContext'
 
 /** https://vike.dev/usePageContext */
 function usePageContext(): ShallowReactive<PageContext> {
-  const pageContext = inject<ShallowReactive<PageContext>>(key)
-  if (!pageContext) throw new Error('setPageContext() not called')
+  const pageContext = inject<ShallowReactive<PageContext>>(key)!
   return pageContext
 }
 

Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,7 @@ const key = 'vike-vue:useData'`
`9`	`9`
`10`	`10`	`/** https://vike.dev/useData */`
`11`	`11`	`function useData<Data>(): ShallowReactive<Data> {`
`12`		`- const data = inject<ShallowReactive<Data>>(key)`
`13`		`- if (!data) throw new Error('setData() not called')`
	`12`	`+ const data = inject<ShallowReactive<Data>>(key)!`
`14`	`13`	`return data`
`15`	`14`	`}`
`16`	`15`
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,7 @@ const key = 'vike-vue:usePageContext'`
`10`	`10`
`11`	`11`	`/** https://vike.dev/usePageContext */`
`12`	`12`	`function usePageContext(): ShallowReactive<PageContext> {`
`13`		`- const pageContext = inject<ShallowReactive<PageContext>>(key)`
`14`		`- if (!pageContext) throw new Error('setPageContext() not called')`
	`13`	`+ const pageContext = inject<ShallowReactive<PageContext>>(key)!`
`15`	`14`	`return pageContext`
`16`	`15`	`}`
`17`	`16`