added positron desktop ide module based on vs code desktop #528
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Positron Desktop IDE module based on the VS Code Desktop module. Positron is a next-generation data science IDE built on VS Code. The module provides a one-click button to launch Positron Desktop from Coder workspaces.
Key Changes
- New Terraform module for Positron Desktop integration with Coder
- Test suite covering various configuration scenarios
- Documentation with usage examples
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| registry/cytoshahar/modules/positron/main.tf | Terraform configuration defining the Positron Desktop app resource with URL construction logic |
| registry/cytoshahar/modules/positron/main.test.ts | Test suite covering default behavior, folder configuration, and open_recent flag combinations |
| registry/cytoshahar/modules/positron/README.md | Module documentation with usage examples and configuration details |
| registry/cytoshahar/README.md | Registry author profile metadata |
| registry/cytoshahar/.images/avatar.jpeg | Author avatar image |
| .icons/positron.svg | Positron application icon |
| locals { | ||
| icon_url = "/icon/positron.svg" | ||
| } |
There was a problem hiding this comment.
The local variable icon_url is defined but never used. The icon path is hardcoded directly on line 51. Either remove this unused local variable or replace the hardcoded value on line 51 with local.icon_url for consistency.
| ```tf | ||
| module "positron" { | ||
| count = data.coder_workspace.me.start_count | ||
| source = "registry.coder.com/coder/positron/coder" |
There was a problem hiding this comment.
The source path is incorrect. It should be registry.coder.com/cytoshahar/positron/coder to match the actual module location in the registry/cytoshahar/modules/positron directory, not registry.coder.com/coder/positron/coder.
| source = "registry.coder.com/coder/positron/coder" | ||
| version = "1.1.1" |
There was a problem hiding this comment.
Version mismatch in the example. The PR description indicates this is version 1.0.0, but the example shows version 1.1.1. Additionally, the source path should be registry.coder.com/cytoshahar/positron/coder to match the actual module location.
| source = "registry.coder.com/coder/positron/coder" | |
| version = "1.1.1" | |
| source = "registry.coder.com/cytoshahar/positron/coder" | |
| version = "1.0.0" |
| import { | ||
| executeScriptInContainer, | ||
| runTerraformApply, | ||
| runTerraformInit, | ||
| testRequiredVariables, | ||
| } from "~test"; |
There was a problem hiding this comment.
Unused import executeScriptInContainer.
Description
Add Positron Desktop IDE module based on VS Code Desktop module
Type of Change
Module Information
Path:
registry/cytoshahar/modules/positronNew version:
v1.0.0Breaking change: [ ] Yes [X] No
Testing & Validation
bun test)bun fmt)Related Issues
None