Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Nov 13, 2025

Summary

  • implement file_edit_insert with optional before/after substring guards plus line_offset fallback, including new runtime tool + unit coverage
  • wire the tool through type defs, tokenizer accounting, redaction, and UI rendering so agents can call it safely
  • refresh tool policy + runtime IPC tests to favor file_edit_insert and ensure redactors/tests understand the new tool

Testing

  • make typecheck
  • make test

Generated with mux

The file_edit_insert tool led to more issues than benefits (unreliable line offset calculations and edge cases). Standardize on file_edit_replace_string as the primary file editing tool.

Changes:
- Remove file_edit_insert tool and all references
- Remove from tool definitions and type exports
- Update UI components to only support replace_string and replace_lines
- Update tests and tool policies
- Update integration tests to use file_edit_replace_string

All 987 unit tests pass; typecheck is clean.
@ammar-agent ammar-agent force-pushed the remove-file-edit-insert branch from 5f3cdbc to 3791c66 Compare November 13, 2025 19:44
@ammar-agent ammar-agent changed the title 🤖 refactor: remove file_edit_insert tool 🤖 feat: add guard-anchored file_edit_insert tool Nov 14, 2025
@ammar-agent ammar-agent marked this pull request as draft November 14, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant