Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: browserify/browserify
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: browserify/browserify
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: require-process
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on Feb 28, 2021

  1. fix require('process') 

    5fe121b added a semi-private `_process` alias for the builtin `process`
shim. Uses of the global `process` would be replaced by
`require('_process')`. That works but you could then not use
`require('process')`. As far as I know that has never worked in
browserify.

There was never a reason for modules to use `require('process')` since
the global is available, but it is a thing that exists that should be
supported. For webpack 5 users it would also be helpful if the core
module shims used `require('process')` because they could take
simpler steps to polyfill the environment correctly. And browserify must
support `require('process')` before we can do that.
    @goto-bus-stop
    goto-bus-stop committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    1d13393 View commit details
    Browse the repository at this point in the history

  2. keep supporting require("_process")

    @goto-bus-stop
    goto-bus-stop committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    2db64f8 View commit details
    Browse the repository at this point in the history
Loading