I don't see a "re-request review" button, so I'll comment here that I implemented your proposed change now.

I addressed your previous comment in my last two commits, which:

• Added 3 tests for "lf" and "crlf" inside the Prettier config.
• Refactored the tests to all be in the same file, since they are all testing the getEndOfLine function.

Edit - Let me look into the rest of the CI failures.

It looks like the snapshots are failing now since I moved the file where the tests are located. Do you know how to fix that?

Edit - Nevermind, I just blew away the existing snapshot. Now I have 1 test error left to debug on my side.

Awesome. Can you add "Fixes #x" to link any issues fixed by this in the PR description?

I don't actually think that this PR fixes any issues/bugs. It may help with #725 and #726, but I don't think it fixes either one.

By the way, I would actually guess that my last PR (#802) fixes #726, but we would need to confirm with MikeMcC399.

@Zamiell do you have any other immediate improvements planned now or should I publish the release?

I do have immediate improvements but wouldn't it be best to release anyway? I think some open source projects (like eslint-plugin-jsdoc) automatically publish in-between every PR, which makes it easier for end-users to test for regressions (i.e. Alice reports that 8.1.3 broke something but 8.1.2 works fine, and then you would know it was from an exact PR).

Yes that's fine. I'll publish now.

@bmish Sounds good. Also, can you respond to this? #347 (comment)