Skip to content

Conversation

@tsawada
Copy link
Contributor

@tsawada tsawada commented Aug 27, 2021

Add SDK versions for the new ruby-build, updated in 6b93011

@tsawada tsawada requested review from kigster and yugui as code owners August 27, 2021 15:04
Copy link
Contributor

@kigster kigster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsawada
Copy link
Contributor Author

tsawada commented Sep 16, 2021

Thanks for your review, @kigster ! Is there anything I need to do to get this merged?

@tsawada
Copy link
Contributor Author

tsawada commented Oct 1, 2021

ping?

@kigster
Copy link
Contributor

kigster commented Oct 1, 2021

Hey, traditionally the latest ruby version in that list is what we use across all test and example projects. That way we can just pull a CI image with 3.0.2 and not have to wait for ruby to build.

I've updated the rest of the codebase to use 3.0.2 in this PR: #114

But it has some issues with docker image somehow. I'll take a look at it shortly however.

@kigster kigster added the duplicate This issue or pull request already exists label Oct 3, 2021
@kigster kigster merged commit 091d577 into bazelruby:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants