-
Notifications
You must be signed in to change notification settings - Fork 670
Add PostgreSQL Operator DDL Support #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add PostgreSQL Operator DDL Support #2096
Conversation
iffyio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, a bit worried that its a lot of code and seems to be lacking test coverage, I tried to point out a few of them but would be good that we do a full pass to ensure code coverage in the PR
src/parser/mod.rs
Outdated
|
|
||
| /// Helper function to parse an operator name (which can contain special characters) | ||
| /// Operator names can be schema-qualified (e.g., schema.operator) | ||
| fn parse_operator_name(&mut self) -> Result<ObjectName, ParserError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this differ from parse_object_name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, the other function does not support correctly the cases where the operator name is + or schema_name.@ etc etc
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Adds support for
CREATE OPERATOR,CREATE OPERATOR FAMILY, andCREATE OPERATOR CLASSstatements.Examples