Provide compatibility with IE11 for source maps. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danelkhen
added a commit
that referenced
this pull request
Jun 12, 2015
Provide compatibility with IE11 for source maps.
Member
|
Very nice! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Dan-el,
IE11 can now use source maps (well, since last year). However it was not working with the file generated by SharpKit.
I have made some small changes to make it work, it is of course still compatible with Chrome and Firefox.
Basically I have included the source root at the beginning of every source file path.
It gives you something like that:
..."sourceRoot":"","sources":["SourceMaps.ashx/C:/Dev/Windows/Ja...For what I have understood, IE looks at the value in the sourceroot property, but the fact that the file names starts with a drive name (i.e. C:/...) seems to confuse him.
I was actually trying to make the debugging works from within Visual Studio (it would have been great, don't you think?) but I couldn't achieve that.
If you remove completely the sourceroot content (just leaving the full path of the files), the browser cannot find anymore the source files but Visual studio does make the link when you start a debug session with IE. However, it does not allow to put a breakpoint in the cs files.
Maybe a bit more digging could do it, I'll try when I have time.
Regards,
Olivier